DIY java CrazyEights problem with drawing cards not adding to displayed hand

I've found every time there was a problem I typed something wrong, and that was the source of my error.  This time, I think though, the error is in the code, and not my fault.

When I find the answer, I will edit this post and display the fix at the bottom.

Here are the two methods that are not working together.  The game plays fine, but the hand will not display the drawn cards that are added to myhand when 'showStatus()' is called.

update:
Two fixes.  It is NOT what the author has. The Boolean isValidPlay(); is the problem.  I will test some more and find out why.  Amazing help from my genius sibling.  I try everything before asking for help, but this time I was dumbfounded.  Still haven't figured out why isValidPlay(); was deleting the cards from my hand.
update:
Found the culprit to the disappearing cards.  It was a remove statement in the 'contains()' function of Hands class.   It totally didn't belong there, no idea why I put it there. So what the book has will work now, and is right.  My bad.  Totally my fault.
FIX #1 -->
private void drawMyCard() {

  Card drewCard = deal();
  print();
  print("You drew the:   " + drewCard);
 
  if (isValidPlay(drewCard.toString())) {
  print("You played the  " + drewCard);
  discardMyCard(drewCard);

  }
  else {
   print("No match: added to hand.");
   myhand.add(drewCard);
  }
 }


FIX #2-->
private void drawMyCard() {

  Card drewCard = deal();
  print();
  print("You drew the:   " + drewCard);
  myhand.add(drewCard);
  if(drewCard.getSuit() == discard.getSuit() || 
    drewCard.getRank() == discard.getRank()) {
   discardMyCard(drewCard);
   print( "You played the  " + drewCard);
  }

 }


update:
I was wrong about the deal(); not working. The cards go into the discard pile when you play them, not when they are dealt... duh... Don't drink wine and code.  Also I should have run some tests to see what was going on.   System.out.println(); is an amazing tool to use!
There is also a fix with the 'CrazyEights.deal():'  that I fixed by using the deck.deal(); instead.  I will probably change that so there is only one 'deal()' method in the CrazyEights main class that deals the cards.  She has one, but it does not remove the cards from the deck, or add them to the discardPile for some reason. I will figure that out too and edit the post.


private void showStatus() {
  print();
  print("Computer # of cards =  " + computerHand.size());
  print("My hand =  " + myhand);
  print("Discard:  " + discard);
  if (discard.getRank()=='8') {
   print("Active suit =  " + activeSuit);

  }

private void drawMyCard() {
  Card drewCard = deck.deal();
  print();
  print("You drew the:   " + drewCard);
  myhand.add(drewCard);
  if (isValidPlay(drewCard.toString())) {
  print("You played the  " + drewCard);
  discardMyCard(drewCard);
  }







Comments

Post a Comment

Popular posts from this blog

JavaScript Ascii animation with while loops and console.log

I was working on figuring out while loops for an exercise in LearnJavaScriptTheHardWay  by Zed Shaw,  and I decided to do this: The red text console.logs were for debugging, and will take over the animation if the comments are removed. The bold red number is the point at which the loop stops.  My CPU didn't have too much trouble with that large number, but I'd recommend dialing it down if your CPU is slow. Also if your CPU is really fast, you'll have to change the pause to something much lower to see the animation better.  That too is in a loop, so the more that pause happens, the more loops your CPU is running.   Link: https://stackoverflow.com/questions/9006988/node-js-on-windows-how-to-clear-console To clear screen as described in link above, uncomment the bold purple comment I tried to comment the code to help learners see what I did,  any comments or suggestions, feel free to drop em in!        ...
Read more

playing with trigonometry sin in pygame

Image
Ok I am so far from understanding, so don't take this as any kind of math lesson. Also, every time I thought I knew what I was doing.... pygame would show me differently. Still a work in progress, but for now, something to play with. Update: SinWaveTime class added to produce that particular weaving effect Tinkering with the different sin wave variables: I wrote this piece separate from my 3D experiment to see how to manipulate the sin wave. While trying to use time as the factor to move my pygame draw circle on the x-axis, i got this crazy little doo-dad : I don't think it's drawing two circles at once, but if I figure out what the heck it's doing I'll let you know.  Or hey if you know, drop a comment.  I don't know if my comments are just not working, or no one wants to. So, here's some pygame code to play with the sin wave.  Alter the different variables to see it in action. picture of SinWave.move_with_time() see changes, SinWaveTime c...
Read more

JavaScript and a Matrix

Image
Screenshot of the code a 10 by 10 matrix Update 5/11/2021 I have successfully used the matrix to create a Snake game in Angular. See the live (Desktop only) game here: Firebase Deploy of Angular S N A K E Update 3/23/2021: I have changed the live version of the game to dynamically create the map for the minesweeper and this allowed for many open windows as to how I can upgrade and add onto the game. The easy version of the game allows people to learn and see how to form a strategy to defeat the original version of the game. There are sounds and options for game type and game size. Click on the options to turn the sound off if loud noises startle you as losing the games results in an explosion noise. Below is the link to the game, hosted on GitHub, and a GitHub link if you'd like to fork the code. Live Game: http...
Read more